Skip to content

send nick change from irc to discord #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 16, 2017
Merged

send nick change from irc to discord #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
284d60b
send nick change fromn irc to discord
May 9, 2017
e2eb354
removed tabs and so
May 9, 2017
4edb307
fixed linter stuff
May 9, 2017
2e96dd7
Added test
May 9, 2017
ec7ca8b
more tests and usage of ircStatusNotices
May 9, 2017
fd88a99
fixed 'nitpick' :D, and only sends to tracked channels,
May 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion lib/bot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ class Bot {
this.formatCommandPrelude = this.format.commandPrelude || 'Command sent from Discord by {$nickname}:';
this.formatIRCText = this.format.ircText || '<{$displayUsername}> {$text}';
this.formatURLAttachment = this.format.urlAttachment || '<{$displayUsername}> {$attachmentURL}';

// "{$keyName}" => "variableValue"
// author: IRC nickname
// text: the (Discord-formatted) message content
Expand Down Expand Up @@ -125,6 +124,20 @@ class Bot {
this.sendToDiscord(author, to, `*${text}*`);
});

this.ircClient.on('nick', (oldNick, newNick, channels) => {
if (!this.ircStatusNotices) return;
channels.forEach((channelName) => {
const channel = channelName.toLowerCase();
if (this.channelUsers[channel]) {
this.channelUsers[channel].delete(oldNick);
this.channelUsers[channel].add(newNick);
this.sendExactToDiscord(channel, `*${oldNick}* is now known as ${newNick}`);
} else {
logger.warn(`No channelUsers found for ${channel} when ${oldNick} changed.`);
}
});
});

this.ircClient.on('join', (channelName, nick) => {
logger.debug('Received join:', channelName, nick);
if (!this.ircStatusNotices) return;
Expand Down
25 changes: 25 additions & 0 deletions test/bot-events.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,31 @@ describe('Bot Events', function () {
this.bot.sendToDiscord.should.have.been.calledWithExactly(author, channel, formattedText);
});

it('should not send name change event to discord', function () {
const channel = '#channel';
const oldnick = 'user1';
const newnick = 'user2';
this.bot.ircClient.emit('nick', oldnick, newnick, [channel]);
this.bot.sendExactToDiscord.should.not.have.been.called;
});

it('should send name change event to discord', function () {
const channel1 = '#channel1';
const channel2 = '#channel2';
const oldNick = 'user1';
const newNick = 'user2';
const bot = createBot({ ...config, ircStatusNotices: true });
bot.connect();
bot.ircClient.emit('names', '#channel1', { [bot.nickname]: '', [oldNick]: '' });
const channelNicksPre = new Set([bot.nickname, oldNick]);
bot.channelUsers.should.deep.equal({ '#channel1': channelNicksPre });
const formattedText = `*${oldNick}* is now known as ${newNick}`;
const channelNicksAfter = new Set([bot.nickname, newNick]);
bot.ircClient.emit('nick', oldNick, newNick, [channel1, channel2]);
bot.sendExactToDiscord.should.have.been.calledWithExactly(channel1, formattedText);
bot.channelUsers.should.deep.equal({ '#channel1': channelNicksAfter });
});

it('should send actions to discord', function () {
const channel = '#channel';
const author = 'user';
Expand Down