Add more end reasons #133
Merged
Add more end reasons #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmmm this doesnt really support #120 ..... And the advice I gave in there doesn't actually work because we'd need to add MISSED etc into the android code.... let me go add those now |
|
OK added MISSED support |
manuquentin
approved these changes
Nov 28, 2019
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS allows 2 more end reasons
call answered elsewhere and call declined elsewhere. add support for these two reasons. Android has quite a few other reasons available but I haven't added them because ios just doesn't support them. Android doesn't support declined elsewhere but I've mapped that in the new constants object to remote ended because technically (in the context of that endpoint) it did.