[iOS 13] Recent changes to continueUserActivity break XCode 10

[bhuangy]

Bug report

• I've checked the example to reproduce the issue.

• Reproduced on:

• Android

• iOS

Description

The changes to use INStartCallIntent break XCode 10 as it cannot find the class. We are currently investigating to see if we can check against the XCode version to avoid breaking the build.

Steps to Reproduce

Build with XCode 10

Logs

Use of undeclared identifier 'INStartCallIntent'

[kylekurz]

This was totally our fault, but it's probably a good time to talk about setting up some CI for this project to avoid things like this. Having a CI system that builds against Xcode 10 and Xcode 11 would have triggered a failed build and we could have decided to either keep it out or do another major rev, as it's a breaking change.

@manuquentin do you want to have that discussion here, or in an email thread or what?

[danjenkins]

Travis offers multiple versions of xcode and is free of charge for open source projects. Can it be that simple?

[sboily]

@manuquentin do you want to have that discussion here, or in an email thread or what?

Please discuss it here or in another thread on Github. But we need to have this discussion public.

[kylekurz]

@bhuangy has a PR up on our fork to fix this, so I think we can rectify the error. I do think adding Travis integration, at least for building the example, is necessary. @manuquentin / @sboily can you guys handle setting that up since you own the repo? From there, we can enforce build success and test code coverage as part of PR acceptance moving forward. I think this one we got lucky, but we should use it to learn and make improvements to the process.