Skip to content

Conversation

whoAbhishekSah
Copy link
Member

Migrate Admin Webhook RPCs to ConnectRPC server

The following RPCs are migrated.

  • CreateWebhook
  • UpdateWebhook
  • DeleteWebhook
  • ListWebhooks

The implementation of the handlers is similar to that of the gRPC handlers.
I have just made it compatible with the ConnectRPC signature.
We have used connect errors instead of gRPC errors.

Copy link

vercel bot commented Sep 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
frontier Ready Ready Preview Comment Sep 11, 2025 6:09am

@coveralls
Copy link

Pull Request Test Coverage Report for Build 17635647680

Details

  • 0 of 108 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 31.8%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/v1beta1connect/webhook.go 0 108 0.0%
Totals Coverage Status
Change from base Build 17635117003: -0.1%
Covered Lines: 10821
Relevant Lines: 34028

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants