[image] add label for ray version and commit #56493
Open
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that it is easier to detect the ray version in the image Signed-off-by: Lonnie Liu <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds version and commit hash labels to the Ray Docker image, which is a great improvement for traceability. The implementation is straightforward. I've suggested a minor improvement to make the version string parsing more robust.
| @@ -7,6 +7,9 @@ CONSTRAINTS_FILE="$3" | |||
| DEST_IMAGE="$4" | |||
| PIP_FREEZE_FILE="$5" | |||
|
|
|||
| RAY_VERSION="$(python python/ray/_version.py | cut -d' ' -f1)" | |||
There was a problem hiding this comment.
Using cut -d' ' -f1 can be brittle if the output format of python/ray/_version.py changes. For example, if there are multiple spaces between the version and commit hash, cut might not extract the version correctly. Using awk '{print $1}' is more robust as it handles any amount of whitespace and will correctly extract the first field.
Suggested change
| RAY_VERSION="$(python python/ray/_version.py | cut -d' ' -f1)" | |
| RAY_VERSION="$(python python/ray/_version.py | awk '{print $1}')" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that it is easier to detect the ray version in the image