-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix timing of thread pool shutdown to respect quarkus.thread-pool.shutdown-interrupt config property #49921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven’t checked the logic but I find that the new variable names add to the confusion as I don’t find them very consistent.
I think we should name the ones coming from the config (after conversion to nanos): configuredShutdownMaxDelay and configuredInterruptMaxDelay (or something similar).
And have consistent naming for shutdown and interrupt when the two variables mean the same thing.
Does it make sense? I’m on my phone so it might not :)
Oh and thanks a lot for having a look and creating a PR :) |
5623f85
to
5d2d863
Compare
Changed to use more meaningful variable names. It seems to me that there's still a bug: if I don't specify
|
Status for workflow
|
quarkus.thread-pool.shutdown-interrupt
is not respected #49733