Adjust the Hibernate ORM's JSON/XML formatter modification checks

[marko-bekhta]

Opening as a draft as it's based on Marco's PR: #49271

I've added "reasons" why the check is failing to help users identify what's been modified and hopefully help them.
Then for the checks themselves ... looking through the Jackson properties:

quarkus/extensions/jackson/runtime/src/main/java/io/quarkus/jackson/runtime/ConfigurationCustomizer.java

Lines 27 to 56 in b7b742e

	if (!jacksonBuildTimeConfig.failOnUnknownProperties()) {
	// this feature is enabled by default, so we disable it
	objectMapper.disable(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES);
	}
	if (!jacksonBuildTimeConfig.failOnEmptyBeans()) {
	// this feature is enabled by default, so we disable it
	objectMapper.disable(SerializationFeature.FAIL_ON_EMPTY_BEANS);
	}
	if (!jacksonBuildTimeConfig.writeDatesAsTimestamps()) {
	// this feature is enabled by default, so we disable it
	objectMapper.disable(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS);
	}
	if (!jacksonBuildTimeConfig.writeDurationsAsTimestamps()) {
	// this feature is enabled by default, so we disable it
	objectMapper.disable(SerializationFeature.WRITE_DURATIONS_AS_TIMESTAMPS);
	}
	if (jacksonBuildTimeConfig.acceptCaseInsensitiveEnums()) {
	objectMapper.enable(MapperFeature.ACCEPT_CASE_INSENSITIVE_ENUMS);
	}
	JsonInclude.Include serializationInclusion = jacksonBuildTimeConfig.serializationInclusion().orElse(null);
	if (serializationInclusion != null) {
	objectMapper.setSerializationInclusion(serializationInclusion);
	}
	ZoneId zoneId = jacksonBuildTimeConfig.timezone();
	if (!zoneId.getId().equals("UTC")) { // Jackson uses UTC as the default, so let's not reset it
	objectMapper.setTimeZone(TimeZone.getTimeZone(zoneId));
	}
	if (jacksonSupport.configuredNamingStrategy().isPresent()) {
	objectMapper.setPropertyNamingStrategy(jacksonSupport.configuredNamingStrategy().get());
	}

I guess unless the user switched back to the defaults -- they are potentially in trouble, so I tried to include that and check the values.

[quarkus-bot]

/cc @gsmet (hibernate-orm)

[mbellade]

Nice, hopefully this will get rid of false positives. Looks like these changes are unrelated to the metamodel checks though, so maybe we can merge this separately without waiting for my PR.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 7a42453.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

[mbellade]

Now that #49321 is in with the fix for HHH-19675 we can merge this and backport to 3.25.

[FroMage]

FTR, my new error message is this:

Caused by: java.lang.IllegalStateException: Persistence unit [<default>] uses Quarkus' main formatting facilities for JSON columns in the database. 
As these facilities are primarily meant for REST endpoints, and they might have been customized for such use, this may lead to undesired behavior, up to and including data loss. 
To address this:
	- If the application does not customize the JSON serialization/deserialization, set "quarkus.hibernate-orm.mapping.format.global=ignore". This will be the default in future versions of Quarkus. 
	- Otherwise, define a custom `FormatMapper` bean annotated with @JsonFormat and @PersistenceUnitExtension to address your database serialization/deserialization needs.
The reasons why the check was triggered are: 
	-Detected 'quarkus.jackson.write-dates-as-timestamps' property set to 'false'. For ObjectMapper being compatible with the clean, default one the expected value is: 'true'.
See the migration guide for more details and how to proceed.

[gsmet]

Thanks to both of you!