feat(TeeFilter): Remove printing stacktraces in the filter #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flx5
force-pushed
the
feature/no-print-stacktrace
branch
from
bbff896 to
cff41f6
Compare
The filter should not print the Stacktrace and then rethrow the exceptions. Other handlers will handle the Servlet Exceptions anyways. Additionally allow users to overwrite the logging output method in the filter. Signed-off-by: flx5 <[email protected]>
flx5
force-pushed
the
feature/no-print-stacktrace
branch
from
cff41f6 to
86bbe5a
Compare
|
@ceki Any chance of getting this reviewed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filter should not print the Stacktrace and then rethrow the exceptions. Other handlers will handle the Servlet Exceptions anyways.
Additionally allow users to overwrite the logging output method in the filter.