Skip to content

Conversation

Neugls
Copy link
Contributor

@Neugls Neugls commented Jul 30, 2025

…so not load the entire sheet into memory

PR Details

make GetSheetDimension read xml tag by stream, using xmlDecoder which used in Rows() method.

Description

Make GetSheetDimension read the xml file in stream, no need to load the entire xml file into memory, so the performance is much better for large Excel files.

@xuri xuri added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 30, 2025
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.24%. Comparing base (d13cd91) to head (a1aedff).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2188   +/-   ##
=======================================
  Coverage   99.24%   99.24%           
=======================================
  Files          32       32           
  Lines       30495    30520   +25     
=======================================
+ Hits        30264    30289   +25     
  Misses        153      153           
  Partials       78       78           
Flag Coverage Δ
unittests 99.24% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. I added unit tests for this changes based on your branch.

@xuri xuri merged commit ce06e70 into qax-os:master Jul 31, 2025
17 checks passed
@xuri xuri moved this to Performance in Excelize v2.10.0 Jul 31, 2025
crush-wu pushed a commit to crush-wu/excelize that referenced this pull request Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Performance
Development

Successfully merging this pull request may close these issues.

2 participants