Skip to content

Fix some more type errors under mypyc #5585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 7, 2018
Merged

Fix some more type errors under mypyc #5585

merged 2 commits into from
Sep 7, 2018

Conversation

msullivan
Copy link
Collaborator

Add test cases for the constructs that triggered the trouble.

@msullivan
Fix some more type errors under mypyc
0f0dcc5 
Add test cases for the constructs that triggered the trouble.
@msullivan msullivan mentioned this pull request Sep 7, 2018
Merged
JukkaL
JukkaL approved these changes Sep 7, 2018
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! These are good examples of errors in stubs and casts that mypyc helped find. Runtime type checking is not only useful for performance.

@JukkaL JukkaL merged commit a0c2c1b into master Sep 7, 2018
@msullivan msullivan deleted the mypy-fixes branch September 7, 2018 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msullivan @JukkaL