Skip to content

gh-71810: Fix _PyLong_AsByteArray() undefined behavior #138873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-71810: Fix _PyLong_AsByteArray() undefined behavior #138873

wants to merge 2 commits into from
+8 −2

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 13, 2025 •
edited by bedevere-app bot
Loading

Don't read p[-1] when p is an empty string: when n==0.

@vstinner
pythongh-71810: Fix _PyLong_AsByteArray() undefined behavior
3906765 
Don't read p[-1] when p is an empty string: when n==0.
@bedevere-app bedevere-app bot mentioned this pull request Sep 13, 2025
Closed
@vstinner vstinner mentioned this pull request Sep 13, 2025
Merged
@vstinner
Copy link
Member Author

cc @skirpichev @serhiy-storchaka

@vstinner vstinner mentioned this pull request Sep 13, 2025
Open
serhiy-storchaka
serhiy-storchaka approved these changes Sep 13, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@skirpichev skirpichev added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Sep 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skirpichev skirpichev skirpichev approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
awaiting merge needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @skirpichev @serhiy-storchaka