What is the current state of this project

[jaseemabid]

Hello 👋🏼

I just wanted to start a discussion about how we can keep this project in sync with upstream click and what the current state of the project is.

• Could we maintain the changes here as a (giant) patch that can be rebased maybe?
• How reasonable would that even be?

[smurfix]

The current process is to merge up to the "official" click repository whenever there's a Click release that somebody (me, so far) thinks merits the not-quite-trivial effort.

Giant patches don't work. There's too many conflicts that need to be resolved. This is fairly straightforward with git and a three-way-merge in your favorite editor but a PITA when you try to apply a patch and get a 50% reject rate.

I haven't yet tackled the 8.2.x merge because Click added typing annotations, moved from restructured text to markdown, and whatnot. (I just looked at the diff, that's what the 50% come from, since there's a conflict in each and every method declaration which asyncclick has converted to async) If you want to tackle this, feel free.

[smurfix]

OK so I have merged to 8.2.2 and pushed that.

There's still some work to be done; in particular I'm sure that there are some typing problems that need to be resolved and which I don't have time for. Help welcome.

Also there are some test failures and idiosyncrasies that I have not found time to debug yet. Shouldn't affect "normal" usage, though.

[Hellseher]

Hi,

I've came here from https://github.com/tortoise/aerich/blob/d82a1e1e21bd044bf7a916c0ef3f2e2dbc05bb62/pyproject.toml#L16 while refreshing the package in Guix index.

Tests fail, which rises the concern for the status of migration.

ImportError while loading conftest '/tmp/guix-build-python-asyncclick-8.2.2.2.drv-0/asyncclick-8.2.2.2/tests/conftest.py'.
tests/conftest.py:3: in <module>
    from click.testing import CliRunner
E   ModuleNotFoundError: No module named 'click'

[smurfix]

Tests fail

Pushed 8.2.2.2.

[jaseemabid]

@smurfix Thank you for the update!