Handle too-long metadata filenames #18658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketheman
reviewed
Sep 9, 2025
| fp.write(wheel_metadata_contents) | ||
| try: | ||
| with open(temporary_filename + ".metadata", "wb") as fp: | ||
| fp.write(wheel_metadata_contents) |
There was a problem hiding this comment.
question: do we know what filesystem max length this is supporting? This is only one limit, and we have other limits in play: S3/B2 max length is <full object path> + filename must be below 1024 - does our filesystem allow for longer than that?
There was a problem hiding this comment.
Since this limit is dependent on the filesystem in use (i.e. it could change in the future) I think we still should guard against this error here like this. If we want to additionally guard against the S3/B2 limits, we should do that as well (but note that the filename & path in the linked issue is much shorter than 1024 characters, so it wouldn't have caught this specific instance).
miketheman
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes WAREHOUSE-PRODUCTION-2A7.