Refresh tokens when pyfa start to avoid expiry #2683
+50
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESI tokens have two components, accesstokens and refreshtokens. Access tokens expire fast and refreshtokens are supposed to be indefinitely available according to CCP. However, refreshtokens in fact have a lifetime of around 30 days. If they are not accessed within 30days you will have to login again. If you have a lot of characters that are infrequently accessed, it is quite troublesome to have to reauth all of them.
This PR ensures that refreshtoken will not expire by validating them and forcing use of refreshtoken when pyfa starts in a background thread so that they will be valid indefinitely.