Skip to content

Conversation

mtskelton
Copy link
Contributor

Ran into the same problem as reported on issue #8 today and implemented a workaround.
It's a somewhat rushed fix so may need some refactoring (which I will do if I have some further free time), but I'm opening the PR in case you find it useful.

@chfw
Copy link
Member

chfw commented Apr 13, 2022

thanks for your PR! could you please write unit tests for your code change?

@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2022

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.37%. Comparing base (80bd1e4) to head (057cea8).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
pyexcel_xlsxr/messy_xlsx.py 92.30% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev       #9      +/-   ##
==========================================
- Coverage   97.52%   97.37%   -0.15%     
==========================================
  Files          11       11              
  Lines         444      457      +13     
==========================================
+ Hits          433      445      +12     
- Misses         11       12       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shrpow
Copy link

shrpow commented Apr 22, 2024

wtf its still not fixed

@chfw chfw merged commit be0613d into pyexcel:dev Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants