Skip to content

Explain linting suppressions #5790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 12, 2025
Merged

Explain linting suppressions #5790

merged 3 commits into from
Aug 12, 2025

Conversation

rhaschke
Copy link
Contributor

@rhaschke rhaschke commented Aug 10, 2025 •
edited
Loading

Description

Explain linting suppressions

@rhaschke
Reduce NOLINT
96593d3
@rhaschke
Revert "Reduce NOLINT"
e2c7550 
This reverts commit 96593d3.
@rhaschke
Explain NOLINT
754cfdb 
We explicitly want to test copying the argument.
@rhaschke rhaschke changed the title Reduce NOLINT Explain linting suppressions Aug 10, 2025
rwgk
rwgk approved these changes Aug 12, 2025
View reviewed changes
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rwgk rwgk merged commit 6292b70 into pybind:master Aug 12, 2025
86 checks passed
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Aug 12, 2025
@rhaschke rhaschke deleted the reduce-nolint branch August 13, 2025 08:03
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwgk rwgk rwgk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rhaschke @rwgk @henryiii