-
Notifications
You must be signed in to change notification settings - Fork 45
Fix parameterization aliases #4070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danielrbradley
wants to merge
10
commits into
master
Choose a base branch
from
fix-param-aliases
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
096ff7d
to
f47118c
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
876433a
to
5664c51
Compare
Don't assume that the provider part of the token is only "azure-native" .. but it will always _start with_ "azure-native".
All refs should already be correct in the schema as we're not updating any tokens now.
Don't require the provider binary on the $PATH. Extract `getProviderBinPath` method for sharing into PulumiTest setup too.
Update for new module & explicit token naming
5463261
to
e15c932
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4019
Replace aliases to submodules to aliases in the potential parameterizations to allow customers to migrate to and from the parameterized providers.
Update the original generation approach to generate the correct tokens into the source metadata and schema.