Skip to content

Conversation

guineveresaenger
Copy link
Contributor

@guineveresaenger guineveresaenger commented Sep 18, 2025

Blog post to announce GCP v9

Adds upgrade example using Neo

@pulumi-bot
Copy link
Collaborator

@guineveresaenger guineveresaenger added area/blog Content issues on blog posts. and removed do-not-merge labels Sep 23, 2025
@guineveresaenger guineveresaenger marked this pull request as ready for review September 23, 2025 23:41
Copy link
Contributor

claude bot commented Sep 23, 2025

Pull Request Review

This blog post announcing GCP v9 has good structure and content, but there are several issues that need to be addressed:

Critical Issues

Missing newline at end of file (line 88): The blog post file must end with a newline per repository standards.

Broken link (line 45): The Oracle Database link is missing the protocol - should be https://www.pulumi.com/registry/packages/gcp/api-docs/oracledatabase instead of pulumi.com/registry/packages/gcp/api-docs/oracledatabase.

Duplicate image reference (lines 79, 88): The same image code-suggestion.png is referenced twice. The second reference (line 88) should likely be migration-prompt.png based on the context about Neo opening a pull request.

Spelling error (line 68): "improvemetns" should be "improvements".

Style Issues

Heading capitalization (line 32): "In Case You missed It - New Modules" should follow sentence case per style guide: "In case you missed it - new modules".

Heading capitalization (line 44): "Model armor" should be "Model Armor" (proper noun capitalization for product names).

Heading capitalization (line 60): "Increased field validation" should be "Increased Field Validation" to match the style of the preceding heading.

Content Suggestions

Date inconsistency: The frontmatter shows date as 2025-09-17, but since this is about a current release, verify this date is accurate.

Image descriptions: Consider adding more descriptive alt text for the screenshot images to improve accessibility.

Call to action: The post would benefit from a clearer call-to-action section at the end encouraging readers to try the new version.

Minor Issues

The post structure and content are generally good, with clear sections and helpful links. The Neo integration example is particularly valuable for users looking to upgrade.

Please address these issues, particularly the critical ones, before merging.

Copy link
Contributor

@Zaid-Ajaj Zaid-Ajaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 💯 thank you

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@guineveresaenger guineveresaenger merged commit 8143633 into master Sep 24, 2025
8 checks passed
@guineveresaenger guineveresaenger deleted the guin/gcp-v9-announce branch September 24, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/blog Content issues on blog posts.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants