Add new logger module #466
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the legacy logger with the new logger module with a bundled console logger with a unified (with other SDKs) logs output format. BREAKING CHANGES: Legacy logger removed and logging to file disabled by default. feat(logger): provide interface for custom loggers Provide interfaces for custom logger implementation. feat(retry-policy): retry policy moved to the network module Retry policy can be applied for all API endpoint groups (not only `subscribe`). refactor(deprecated): removed `packetSizeForOperation` Removed previously deprecated `packetSizeForOperation` methods group along with `size` builder from the `PubNub` client. refactor(deprecated): removed `retry` from status object Removed previously deprecated `retry` and `cancelAutomaticRetry` methods along with the `automaticallyRetry` property from API processing status objects. BREAKING CHANGES: To retry the last API call, same request object to the corresponding method. refactor(deprecated): removed obsolete properties from `status` and `result` objects. Removed previously deprecated properties: `TLSEnabled`, `authKey`, `origin`, `userID`, `uuid`, and `statusCode`. BREAKING CHANGES: Most of the removed values can be retrieved from the client configuration, and the API processing HTTP status code was removed in favor of `category` fields. refactor(deprecated): removed deprecated configuration options Removed previously deprecated `uuid`, `deviceID`, `applicationExtensionSharedGroupIdentifier`, and `completeRequestsBeforeSuspension` configuration options. BREAKING CHANGES: `uuid` has been removed in favor of the `userID` property.
parfeon
added
status: done
🎉 Snyk checks have passed. No issues have been found so far. |
Add `limit` and `offset` parameters for `PNHereNowRequest` for pagination support.
Fix the issue where an immediate 'unsubscribe' after receiving a response from a subscription may cause a race condition where the next 'subscribe' is in the process of scheduling and can't be cancelled, causing 'leave' to time out. fix(cocoapods): address classes visibility Fix the issue because of which private classes leaked into public headers and the CocoaPod build failed.
jguz-pubnub
reviewed
Sep 18, 2025
| // | ||
| // PubNub Real-time Cloud-Hosted Push API and Push Notification Client Frameworks | ||
| // Copyright (c) 2013 PubNub Inc. | ||
| // Copyright (c) 2013 PubNub Inc./Users/sergey/Documents/Develop/Objective-C/PubNub SDK (master)/PubNub.podspec |
There was a problem hiding this comment.
It seems that custom path has been accidentally inserted here
jguz-pubnub
reviewed
Sep 18, 2025
| .macOS(.v10_11), | ||
| .tvOS(.v10), | ||
| .watchOS(.v4) | ||
| .iOS(.v14), |
There was a problem hiding this comment.
I like that the deployment targets were increased, but I’m curious - was there a specific reason or change in this PR that required increasing them?
jguz-pubnub
reviewed
Sep 18, 2025
There was a problem hiding this comment.
It seems that deployment targets haven't been updated in the PubNub.podspec file as you did in Package.swift
jguz-pubnub
reviewed
Sep 18, 2025
| } | ||
|
|
||
| - (void)channelsForGroup:(NSString *)group withCompletion:(PNGroupChannelsAuditCompletionBlock)block { | ||
| [self.logger warnWithLocation:@"PubNub" andMessageFactory:^PNLogEntry * { |
There was a problem hiding this comment.
Should we log deprecated method calls? The caller will already receive a warning message in the IDE (Xcode)
jguz-pubnub
reviewed
Sep 18, 2025
| return [PNStringLogEntry entryWithMessage:@"Unsubscribe all channels and groups"]; | ||
| }]; | ||
|
|
||
| dispatch_queue_t queue = dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0); |
There was a problem hiding this comment.
Why do we need dispatch_after here?
|
I have a general question: should we really add separate logs when a caller invokes a deprecated method? This occurs in many places, and the IDE should already provide a warning. I don't think this should be the logger mechanism's responsibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(logger): add new logger module
Replace the legacy logger with the new logger module with a bundled console logger with a unified (with other SDKs) logs output format.
BREAKING CHANGES: Legacy logger removed and logging to file disabled by default.
feat(logger): provide interface for custom loggers
Provide interfaces for custom logger implementation.
feat(here-now): add
limitandoffsetparametersAdd 'limit' and 'offset' parameters for 'PNHereNowRequest' for pagination support.
feat(retry-policy): retry policy moved to the network module
Retry policy can be applied for all API endpoint groups (not only
subscribe).refactor(deprecated): removed
packetSizeForOperationRemoved previously deprecated
packetSizeForOperationmethods group along withsizebuilder from thePubNubclient.refactor(deprecated): removed
retryfrom status objectRemoved previously deprecated
retryandcancelAutomaticRetrymethods along with theautomaticallyRetryproperty from API processing status objects.BREAKING CHANGES: To retry the last API call, same request object to the corresponding method.
refactor(deprecated): removed obsolete properties from
statusandresultobjects.Removed previously deprecated properties:
TLSEnabled,authKey,origin,userID,uuid, andstatusCode.BREAKING CHANGES: Most of the removed values can be retrieved from the client configuration, and the API processing HTTP status code was removed in favor of
categoryfields.refactor(deprecated): removed deprecated configuration options
Removed previously deprecated
uuid,deviceID,applicationExtensionSharedGroupIdentifier, andcompleteRequestsBeforeSuspensionconfiguration options.BREAKING CHANGES:
uuidhas been removed in favor of theuserIDproperty.