Some cleanups in the parallel code #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, I don't remember at which point I wrongly mistyped samples, but the match clause from line 2202 to 2206 (in your PR) can be removed. We can always concatenate the samples since most of the time we do not have anything in there, and even if we do it should not be costly (they would not be really really long lists). Otherwise, feel free to change the match in L2202 to {worker_msg, #pass{performed = PassedRcvd, samples = []}, From, Id} -> |
|
Let us discuss the issue a bit, once you have some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is also a place where a type error exists - @pablocostass please take a look