Skip to content

Add pre-allocation to EscapeMetricFamily #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add pre-allocation to EscapeMetricFamily #828

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8c70ff
pre-allocate slices
boekkooi-impossiblecloud Sep 2, 2025
e1f4bae
pre-allocate strings.Builder for UnderscoreEscaping
boekkooi-impossiblecloud Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion model/metric.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,9 @@ func EscapeMetricFamily(v *dto.MetricFamily, scheme EscapingScheme) *dto.MetricF
} else {
out.Name = proto.String(EscapeName(v.GetName(), scheme))
}
if v.Metric != nil {
out.Metric = make([]*dto.Metric, 0, len(v.Metric))
}
for _, m := range v.Metric {
if !metricNeedsEscaping(m) {
out.Metric = append(out.Metric, m)
Expand All @@ -369,7 +372,9 @@ func EscapeMetricFamily(v *dto.MetricFamily, scheme EscapingScheme) *dto.MetricF
Histogram: m.Histogram,
TimestampMs: m.TimestampMs,
}

if m.Label != nil {
escaped.Label = make([]*dto.LabelPair, 0, len(m.Label))
}
for _, l := range m.Label {
if l.GetName() == MetricNameLabel {
if l.Value == nil || IsValidLegacyMetricName(l.GetValue()) {
Expand Down Expand Up @@ -424,6 +429,7 @@ func EscapeName(name string, scheme EscapingScheme) string {
if IsValidLegacyMetricName(name) {
return name
}
escaped.Grow(len(name))
for i, b := range name {
if isValidLegacyRune(b, i) {
escaped.WriteRune(b)
Expand Down
Loading