WIP: expfmt/text: optionally include empty MetricFamilies #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing text format it is sometimes useful to keep all the MetricFamilies around, even the ones that don't have any timeseries. This is the case for the testutil library in client_golang where we need to distinguish registered metrics from erronous inputs. Signed-off-by: Damien Grisonnet <[email protected]>
dgrisonnet
force-pushed
the
fix-compare-absent-metrics
branch
from
a7244c2 to
a51096f
Compare
dgrisonnet
commented
Oct 10, 2024
Comment on lines
-79
to
-82
| // Fail-fast checks. | ||
| if len(in.Metric) == 0 { | ||
| return 0, fmt.Errorf("MetricFamily has no metrics: %s", in) | ||
| } |
There was a problem hiding this comment.
Tests are failing because of this. I guess I will need to introduce a new function just to keep MetricFamilies without timeseries around
There was a problem hiding this comment.
...or variadic option 🤔 or "both", so
NewMFConverter(opts).MetricFamilyToText
then keeping MetricFamilyToText as NewMFConverter(nil).MetricFamilyToText(....)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing text format it is sometimes useful to keep all the MetricFamilies around, even the ones that don't have any timeseries. This is the case for the testutil library in client_golang where we need to distinguish registered metrics from erronous inputs.