Update the description field on open issues #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andriy Mykhaylyk <[email protected]>
Signed-off-by: Andriy Mykhaylyk <[email protected]>
bwplotka
approved these changes
Mar 5, 2021
erdii
approved these changes
Mar 5, 2021
erdii
added a commit
to erdii/jiralert
that referenced
this pull request
Mar 9, 2021
Signed-off-by: Josh Gwosdz <[email protected]>
erdii
added a commit
to erdii/jiralert
that referenced
this pull request
Mar 10, 2021
Signed-off-by: Josh Gwosdz <[email protected]>
erdii
added a commit
that referenced
this pull request
Mar 10, 2021
* hash group labels to get the issue search label Signed-off-by: Josh Gwosdz <[email protected]> * make group label hashing easier to read and disable errcheck linting for hash.Write call Signed-off-by: Josh Gwosdz <[email protected]> * run go mod tidy Signed-off-by: Josh Gwosdz <[email protected]> * hide label hashing behavior behind flag Signed-off-by: Josh Gwosdz <[email protected]> * ignore never occuring error the go way 💪 Signed-off-by: Josh Gwosdz <[email protected]> * use JIRALERT{hash...} issue label to make the origin clear Signed-off-by: Josh Gwosdz <[email protected]> * document -hash-jira-label Signed-off-by: Josh Gwosdz <[email protected]> * document -hash-jira-label changes Signed-off-by: Josh Gwosdz <[email protected]> * adapt tests of #75 Signed-off-by: Josh Gwosdz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed a use case that was not covered - updates from alertmanager updated the summary but not the description.
That's a big piece of missing functionality - we would like the description to also be updated on new alerts, not only summary.
We also think it would be useful for other users, so that's why this pull-request is here.