Moved all root files to separate packages. #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bartek Plotka <[email protected]>
free
approved these changes
Mar 19, 2019
There was a problem hiding this comment.
LGTM
With apologies for the delay. I didn't even have the time to look at the email until now and only did so because I noticed it said "zero logic changes", so I figured it would be quick.
Out of curiosity, what's the benefit of putting every file in its own package?
|
Sure:
It's not that big deal just easier to work with over time -> and unit test (!) at some point 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0 logic change.
Also
modulein go.mod was utterly wrong. Now all should work properly.Signed-off-by: Bartek Plotka [email protected]