Allow to specify ES_USERNAME/ES_PASSWORD environment variables to connect to the ES node #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumelecerf
force-pushed
the
feature/support-username-password
branch
2 times, most recently
from
e083664 to
bb14199
Compare
This was referenced Jul 27, 2021
guillaumelecerf
force-pushed
the
feature/support-username-password
branch
from
bb14199 to
28a6bf3
Compare
guillaumelecerf
changed the title
|
Arg, seems duplicating #308 |
…nect to the ES node Signed-off-by: Guillaume Lecerf <[email protected]>
guillaumelecerf
force-pushed
the
feature/support-username-password
branch
from
28a6bf3 to
fa71388
Compare
guillaumelecerf
changed the title
|
To address this comment, I change my approach to only accept credentials from the environment variables. |
|
Thanks @sysadmind ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.