Skip to content

Fix snapshot_stats metrics which happens on HA hdfs type snapshot rep… #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2021
Merged

Fix snapshot_stats metrics which happens on HA hdfs type snapshot rep… #442

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f20bba
Fix snapshot_stats metrics which happens on HA hdfs type snapshot rep…
bydeath Jun 17, 2021
3bad103
Fix issue #415
bydeath Jun 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions collector/snapshots_reponse.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,6 @@ type SnapshotStatDataResponse struct {

// SnapshotRepositoriesResponse is a representation snapshots repositories
type SnapshotRepositoriesResponse map[string]struct {
Type string `json:"type"`
Settings map[string]string `json:"settings"`
Type string `json:"type"`
Settings map[string]interface{} `json:"settings"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we don't use the value of settings anywhere, we could just remove the field 🤔

Copy link
Contributor Author

@bydeath bydeath Jun 18, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the value of settings is not used now. I tried it worked without Settings field, and it's another way to fix the bug.

}