Skip to content

Conversation

Paulie-Aditya
Copy link

Fixes #3527

Changes:
State variable was linewrap but was getting referenced as wordwrap, so even though the dispatch function was working, the state wasn't getting updated

I have verified that this pull request:

  • [ ✅] has no linting errors (npm run lint)
  • [✅ ] has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • [✅ ] is descriptively named and links to an issue number, i.e. Fixes #123

Copy link

welcome bot commented Sep 11, 2025

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@Paulie-Aditya
Copy link
Author

Paulie-Aditya commented Sep 11, 2025

Working as expected now:

Recording.2025-09-11.130617.mp4

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your work on this, I think this overall feels good!

It seems like the only issue here might be that the Preferences.unit.test.jsx might need to be updated to align with the changes here in the Preferences component.

I do also think it's a bit confusing to have both linewrap and wordwrap within the repository—we may want to stick to one term in the future! Maybe after this is merged in, there could be another issue for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

word wrap off still wraps
2 participants