feat: use command dispatcher for pixi build #4156
Conversation
| let file_name = built_source | ||
| .output_file | ||
| .file_name() | ||
| .expect("the build backend did not return a file name"); |
There was a problem hiding this comment.
should it be an error? or it is something that we expect to never really happen?
There was a problem hiding this comment.
No, if this happened, then the backend returned an empty string.
| Outputs { outputs: Vec<CondaOutput> }, | ||
| } | ||
|
|
||
| impl CachedCondaMetadata { |
There was a problem hiding this comment.
I was thinking, does it make sense to make SourceMetadataCache::entry a trait that return CachedCondaMetadata?
and we implement it for SourceMetadataCache?
There was a problem hiding this comment.
What is the point of adding a trait though? Its not reused.
|
|
||
| // Canonicalize the output directory and package path. | ||
| let output_dir = dunce::canonicalize(&args.output_dir) | ||
| .expect("failed to canonicalize output directory which must now exist"); |
There was a problem hiding this comment.
same here - should we make it a nice error?
There was a problem hiding this comment.
No this cannot happen due to user error. If at this point the output directory cannot be canonicalized it means that the build didnt actually put a package there which is a developer error if thats the case.
This PR updates the
pixi buildcommand to use the command dispatcher and with it the latest protocol version.