-
Notifications
You must be signed in to change notification settings - Fork 17
feat(ros): additional package maps #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review, love the functionality
Some additions:
|
0bb882c
to
e6fe01c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im not sure about the robostacknto conda rename. It makes it slightly harder to migrate from the robostack based file. Can we instead allow both keys and not rename the keys in the bundled file?
I would also prefer to create seperate PRs for these changes because this PR is already becoming very large.
Might also be nice to have a follow-up PR to be able to create the mapping inline. I was discussing this with someone in the prefix.dev robotics discord. It also makes it easier to create a stand-alone example or test :) |
hey! I've tested the PR, and it works as expected! and will try to build it like this: Is it expected? |
@nichmor thanks for the review. I had that as intended behaviour, but indeed it might be confusing. Now I throw an value error. |
thanks! let me retry it, and I think we can merge it after that |
0749ea4
to
36f837f
Compare
works as expected, thanks a lot! |
This allows for an additional key in the
package.build.config
:This will add/overwrite the mappings from
robostack
e.g. if you host your own packages.An additional (later) option would be to let packages allow to install the mapping file inside the build environment.
I also added a
test
enviroment to thepixi.toml
such that it is easy to develop and test within pycharm.You can now open a pycharm session inside the
pixi-build-ros
test
environment and select the correct interpreter. Then you can run thepytest
withinpycharm
.