Skip to content

Conversation

developit
Copy link
Member

This fixes a memory leak caused by all signals being addressable from our internal ROOT signal. We never ended up using the root signal, and removing it means computed graphs within components get nicely GC'd when unmounted.

@changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2022

🦋 Changeset detected

Latest commit: ad5d6f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preact/signals-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Sep 10, 2022

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit ad5d6f4
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/631d0944de4d4e00095fae7b
😎 Deploy Preview https://deploy-preview-117--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 10, 2022

Size Change: +18 B (0%)

Total Size: 59.8 kB

Filename Size Change
docs/dist/assets/basic.********.js 220 B +3 B (+1%)
docs/dist/assets/client.********.js 45.8 kB -2 B (0%)
docs/dist/assets/index.********.js 1.11 kB +46 B (+4%)
docs/dist/assets/signals-core.module.********.js 859 B -11 B (-1%)
packages/core/dist/signals-core.js 993 B -11 B (-1%)
packages/core/dist/signals-core.mjs 822 B -7 B (-1%)
ℹ️ View Unchanged
Filename Size
docs/dist/assets/signals.module.********.js 5.67 kB
docs/dist/assets/style.********.css 585 B
packages/preact/dist/signals.js 1.13 kB
packages/preact/dist/signals.mjs 1.12 kB
packages/react/dist/signals.js 798 B
packages/react/dist/signals.mjs 753 B

compressed-size-action

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@marvinhagemeister marvinhagemeister merged commit f1da96b into main Sep 10, 2022
@marvinhagemeister marvinhagemeister deleted the remove-root-signal branch September 10, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants