Change default datetime in query from '0000-00-00' to '1970-01-01' #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent versions of MySQL do not allow `0000-00-00` so the default Transaction database query keeps failing causing a `null` value on the `setReceipt()` function. Change to epoch which is allowed
Due to new messages e.g. mshwari, some transactions from were being saved as empty records with only the default values and the message saved as a note. This solves that problem by checking whether the parsed amount is greater than 0 before saving. Otherwise it returns true.
Akazabre
approved these changes
Jul 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent versions of MySQL do not allow
0000-00-00so the default Transaction database query keeps failing causing anullvalue on thesetReceipt()function. Change to epoch which is allowedFixes #22