-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add composer.json.in to ext/skeleton for PIE support #19853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add composer.json.in to ext/skeleton for PIE support #19853
Conversation
It might be worth thinking about whether to put the vendor name in the generated extension name. Since vendor is going to be present anyway and it'd be better to avoid extension name conflicts in community extensions from different vendors. Not too sure how this would work or if / can even be put into an extension name though... |
That's up to each vendor to select their extension name. Extension names must follow the regex |
Right, I suppose the backwards compatibility constraint is a bit awkward. Side note: I've tried the underscore thing before for vendor separation, it's not ideal because the --enable flag becomes a mix of - and _, e.g. |
ya, I understand the concern, but I think perhaps a little out of scope of this change 😁 |
Is |
b46c7d0
to
dd1997c
Compare
The composer CLI and Packagist require the vendor name to match |
Indeed, it's a good point, that's why I explicitly changed the vendor name to something invalid: "name": "<your-vendor-here>/%EXTNAME%", This means it will not pass |
What about requiring the vendor as an arg to the generator? |
Pending acceptance of RFC https://wiki.php.net/rfc/adopt_pie_deprecate_pecl - this PR will add a basic
composer.json
definition to the skeleton extensionFixes php/pie#368