Skip to content

Conversation

C-D-Lewis
Copy link
Contributor

@C-D-Lewis C-D-Lewis commented Aug 14, 2025

Goes some way to fixing #44 by testing creating projects from the snippets, and fixing dead links and small errors in code.

Also includes full source-code files as an expandable at the end instead of relying on a third-party Gist.

  • Fix way outdated mobile nav
  • C tutorial
  • JS tutorial
  • Advanced tutorials? Requires missing example files (PDC SVG Zip file)

@C-D-Lewis
Copy link
Contributor Author

@Sorixelle Seems GitHub's auto-merge main feature doesn't add the signed off by. Is that still an issue?

@C-D-Lewis
Copy link
Contributor Author

@Sorixelle De-scoping the "Advanced Tutorials" section that contains only the PDC tutorial because it requires some files that I can't find anymore - broken link to the Pebble S3. It can be done in a follow-up PR.

@Sorixelle
Copy link
Member

Sorixelle commented Aug 31, 2025

Seems GitHub's auto-merge main feature doesn't add the signed off by. Is that still an issue?

It is annoying but the checks don't like it, yeah. Generally, prefer rebases over merging to update a branch - it doesn't create an extra commit.

Sorry it's taken me so long to get to this one - gotta find time to properly look through the changes.

@C-D-Lewis
Copy link
Contributor Author

Seems GitHub's auto-merge main feature doesn't add the signed off by. Is that still an issue?

It is annoying but the checks don't like it, yeah. Generally, prefer rebases over merging to update a branch - it doesn't create an extra commit.

Sorry it's taken me so long to get to this one - gotta find time to properly look through the changes.

Gotcha, I'll update it soon. Thanks for your review! No problem 😄

@C-D-Lewis
Copy link
Contributor Author

@Sorixelle Things seem happier now!

Merge latest main

Signed-off-by: C-D-Lewis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants