Investigate why PL Node does not render the Demo homepage correctly

[bmuenzenmeyer]

http://demo.patternlab.io/?p=pages-homepage when run with Pattern Lab Node does not show you the blog posts. The header also seems off. The demo uses a lot of native arrays, with data merging of page-level json. Investigate, fix, cover with unit tests

Expected

Actual

[bmuenzenmeyer]

🕵️ After some investigation - I've discovered the culprit: block-media@inreview.mustache when included across two different patterns. In the case above, the home page renders this fine but subsequent renders do not. Rather that track down the exact reason for this, we are dropping support for the old method in favor of the markdown approach

This syntax for documenting patterns has been for a while to use the companion markdown file instead of this file convention. Removing the @inreview from the filename restores the functionality expected.

Adding a note in the upgrade instructions about this.

[bradfrost]

Nice sleuthing, @bmuenzenmeyer!

[bmuenzenmeyer]

Thanks @bradfrost - I've also replaced that code within pattern-lab/starterkit-mustache-demo@16c7961