Skip to content

Conversation

skalwaghe-56
Copy link
Contributor


This PR adds a regression test for GH#40252. Confirms that interpolate(method="time") now works correctly on nullable Int64 and Float64 dtypes. No code changes, test-only. Ensures the behavior is locked in to prevent regressions.

Thanks!

@skalwaghe-56
Copy link
Contributor Author

@jbrockmendel Request you to review and let me know!

@skalwaghe-56 skalwaghe-56 force-pushed the test-interpolate-time-nullable branch from e4404b9 to d4f4b85 Compare September 8, 2025 14:02
@skalwaghe-56
Copy link
Contributor Author

@jorisvandenbossche Kindly request you to check and let me know!

@skalwaghe-56 skalwaghe-56 force-pushed the test-interpolate-time-nullable branch 5 times, most recently from 8dfdeea to 63e8fb5 Compare September 10, 2025 10:43
@simonjayhawkins simonjayhawkins added the Testing pandas testing functions or related to the test suite label Sep 10, 2025
@skalwaghe-56 skalwaghe-56 force-pushed the test-interpolate-time-nullable branch 2 times, most recently from d009ce2 to 1385907 Compare September 11, 2025 14:31
@skalwaghe-56
Copy link
Contributor Author

@jbrockmendel Request you to kindly check this.

@skalwaghe-56 skalwaghe-56 force-pushed the test-interpolate-time-nullable branch 5 times, most recently from 353ab8c to f6501ee Compare September 17, 2025 16:56
@skalwaghe-56 skalwaghe-56 force-pushed the test-interpolate-time-nullable branch 2 times, most recently from cfae1a2 to 5a98788 Compare September 20, 2025 08:57
Copy link
Contributor

@Alvaro-Kothe Alvaro-Kothe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I feel like your test should be parametrized instead of casting the dataframe.

@skalwaghe-56 skalwaghe-56 force-pushed the test-interpolate-time-nullable branch 2 times, most recently from 22c1bca to 62e8c48 Compare September 23, 2025 12:31
@skalwaghe-56 skalwaghe-56 force-pushed the test-interpolate-time-nullable branch from 62e8c48 to 2039bfa Compare September 24, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Interpolate over time does not work with Int64 or Float64
4 participants