-
-
Notifications
You must be signed in to change notification settings - Fork 19k
BUG: fix .str.isdigit to honor unicode superscript for older pyarrow #61962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: fix .str.isdigit to honor unicode superscript for older pyarrow #61962
Conversation
pandas/tests/strings/test_strings.py::test_isnumeric_unicode |
Yeah, see #61466 (comment) (but I suppose the best option is just to accept that difference and update the test to reflect it. Alternatively we could still only use pyarrow for ascii, and always fall back to python for unicode, if we really want consistent behaviour) |
cc @mroeschke this should also fix the doctest failure on main |
pandas/core/strings/accessor.py
Outdated
3 False | ||
dtype: bool | ||
Notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error:...:GL07:pandas.Series.str.isdigit:Sections are in the wrong order. Correct order is: Returns, See Also, Notes, Examples
Thanks @jorisvandenbossche (the other failures appear to be due to a numexpr upgrade) |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Manual backport -> #62476 |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.