Skip to content

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche added this to the 2.3.2 milestone Jul 26, 2025
@jorisvandenbossche jorisvandenbossche added Strings String extension data type and string data Arrow pyarrow functionality labels Jul 26, 2025
@jbrockmendel
Copy link
Member

pandas/tests/strings/test_strings.py::test_isnumeric_unicode

@jorisvandenbossche
Copy link
Member Author

pandas/tests/strings/test_strings.py::test_isnumeric_unicode

Yeah, see #61466 (comment) (but I suppose the best option is just to accept that difference and update the test to reflect it. Alternatively we could still only use pyarrow for ascii, and always fall back to python for unicode, if we really want consistent behaviour)

@jorisvandenbossche jorisvandenbossche modified the milestones: 2.3.2, 2.3.3 Aug 21, 2025
@jorisvandenbossche
Copy link
Member Author

cc @mroeschke this should also fix the doctest failure on main

3 False
dtype: bool
Notes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error:...:GL07:pandas.Series.str.isdigit:Sections are in the wrong order. Correct order is: Returns, See Also, Notes, Examples

@mroeschke mroeschke merged commit f14f131 into pandas-dev:main Sep 25, 2025
23 of 42 checks passed
@mroeschke
Copy link
Member

Thanks @jorisvandenbossche (the other failures appear to be due to a numexpr upgrade)

Copy link

lumberbot-app bot commented Sep 25, 2025

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 f14f131805aa07f3f2e2a4b8185520e916f01be4
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #61962: BUG: fix .str.isdigit to honor unicode superscript for older pyarrow'
  1. Push to a named branch:
git push YOURFORK 2.3.x:auto-backport-of-pr-61962-on-2.3.x
  1. Create a PR against branch 2.3.x, I would have named this PR:

"Backport PR #61962 on branch 2.3.x (BUG: fix .str.isdigit to honor unicode superscript for older pyarrow)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@jorisvandenbossche
Copy link
Member Author

Manual backport -> #62476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrow pyarrow functionality Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Series.str.isdigit with pyarrow dtype doesn't honor unicode superscripts
3 participants