chore!: upgrade mock server in FFI #502
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JP-Ellis
force-pushed
the
chore/upgrade-mock-server-in-ffi
branch
from
6346a9a to
fd6665f
Compare
This removes the two deprecated functions, and adapts the tests to make
use of the remaining non-deprecated function
`pactffi_create_mock_server_for_transport`; all in preparation to
upgrade the mock server dependency to version 2.
BREAKING CHANGE: The functions `pactffi_create_mock_server` and
`pactffi_create_mock_server_for_pact` have been removed following
their deprecation. Please use the newer
`pactffi_create_mock_server_for_transport` function.
Signed-off-by: JP-Ellis <[email protected]>
I have overhauled the consumer example to: - Use `CMake` and the Corrosion package to automatically find and build the FFI (including the header) and link to the necessary dependencies. - Separate out the tests into individual files to help with the end-users' understanding of the tests. The initial motivation was to remove the reliance on deprecated FFI functions. Signed-off-by: JP-Ellis <[email protected]>
JP-Ellis
force-pushed
the
chore/upgrade-mock-server-in-ffi
branch
from
fd6665f to
aa6e96a
Compare
Signed-off-by: JP-Ellis <[email protected]>
JP-Ellis
force-pushed
the
chore/upgrade-mock-server-in-ffi
branch
from
aa6e96a to
c50ddc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.