Skip to content

Conversation

davigonz
Copy link
Contributor

@davigonz davigonz commented Jul 31, 2019

Fixes #2612

QA

Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Release_2.12.0/2613%20-%20trigger%20media%20scan.md

Bugs & improvements:

@davigonz davigonz self-assigned this Jul 31, 2019
@davigonz davigonz requested review from jesmrec and hosy July 31, 2019 11:11
@davigonz davigonz changed the title Fix/trigger media scan Fix trigger media scan Jul 31, 2019
@davigonz davigonz force-pushed the fix/trigger_media_scan branch from 0c4ece0 to c2e1213 Compare July 31, 2019 11:12
@davigonz davigonz force-pushed the fix/trigger_media_scan branch from c2e1213 to 7d3ba83 Compare July 31, 2019 11:15
@davigonz
Copy link
Contributor Author

@jesmrec media scan triggering stopped working due to some changes we performed to make uploads and downloads with wrapped apps properly worked so could you test them to see that are still working?

@davigonz
Copy link
Contributor Author

davigonz commented Aug 1, 2019

@jesmrec code approved, ready to test

@jesmrec
Copy link
Collaborator

jesmrec commented Aug 1, 2019

(1)

I think this is not a problem in the oC app, but just in case: .mov files are not displayed in the Gallery (after checking different formats). Am i wrong or can we do something? @davigonz

@jesmrec
Copy link
Collaborator

jesmrec commented Aug 1, 2019

(2) READY TO TEST

@jesmrec media scan triggering stopped working due to some changes we performed to make uploads and downloads with wrapped apps properly worked so could you test them to see that are still working?

about this. I compared the behaviour in version 2.11.0 and the current fix. With the fix, the pics are not displayed after being downloaded. Unfortunately, the behaviour is not the same (due to the fix?)

MI wrapper 8.5 Gen1

With Android 2.11.0, pics downloaded and displayed correctly:

2 11 1

With the fix, download error

2 11 1-fail

Tested with Android 5X v8 and Samsung S9 v9

I can provide as many wrapped apks as needed.

@davigonz
Copy link
Contributor Author

davigonz commented Aug 1, 2019

I think this is not a problem in the oC app, but just in case: .mov files are not displayed in the Gallery (after checking different formats). Am i wrong or can we do something? @davigonz

.mov is a format created by Apple so I guess Android does not support it by default.

Some users reported the same problem on S9 devices => https://www.reddit.com/r/GalaxyS9/comments/9t9dif/mov_files_not_showing_in_my_gallery/

@jesmrec
Copy link
Collaborator

jesmrec commented Aug 2, 2019

(2) is fixed. But here we have gone to the scratch point. Now, pics are correctly downloaded and previewed in both wrapped and non-wrapped apps. But the Samsung gallery only shows the pics when the app is non-wrapped. That means, the initial bug persists if the app is MI-wrapped. Any other workaround is posible here @davigonz?

CC @michaelstingl

@davigonz
Copy link
Contributor Author

davigonz commented Aug 2, 2019

But here we have gone to the scratch point. Now, pics are correctly downloaded and previewed in both wrapped and non-wrapped apps. But the Samsung gallery only shows the pics when the app is non-wrapped. That means, the initial bug persists if the app is MI-wrapped. Any other workaround is posible here @davigonz?

This is how the wrapped apps work, files contained in the wrapped app container should not be accessible from other apps (including the gallery), but only from other wrapped apps. Otherwise, the wrapped apps would not be secure since they would be exposing their data to any app.

@jesmrec
Copy link
Collaborator

jesmrec commented Aug 2, 2019

Ok, then, everything fixed. Approved on my side.

@davigonz davigonz merged commit e1c49f7 into master Aug 2, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/trigger_media_scan branch August 2, 2019 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Images are not detected in Android 9 gallery after being downloaded
3 participants