Skip to content

Conversation

alexGNX
Copy link
Contributor

@alexGNX alexGNX commented Aug 28, 2025

Description

Add support for okms_secret (resource and data source). The secrets API is still exposed internally only for now, but will be in public beta in a few weeks

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

export TF_ACC=1
export OVH_ENDPOINT=ovh-eu
export OVH_APPLICATION_KEY=...
export OVH_APPLICATION_SECRET=...
export OVH_CONSUMER_KEY=...
export OVH_OKMS=...

# data source tests
go test -timeout 30s -run ^TestAccOkmsSecretDataSource_latestAndVersions$ github.com/ovh/terraform-provider-ovh/v2/ovh
go test -timeout 60s -run ^TestAccOkmsSecretDataSource_latestAndVersions$ github.com/ovh/terraform-provider-ovh/v2/ovh

# resource tests
go test -timeout 90s -run ^TestAccOkmsSecretResource_basicLifecycle$ github.com/ovh/terraform-provider-ovh/v2/ovh
go test -timeout 5m -run TestAccOkmsSecretResource_basicLifecycle github.com/ovh/terraform-provider-ovh/v2/ovh
go test -timeout 5m -run TestAccOkmsSecretResource_casMismatch github.com/ovh/terraform-provider-ovh/v2/ovh
go test -timeout 5m -run TestAccOkmsSecretResource_pathRecreateAndMetadata github.com/ovh/terraform-provider-ovh/v2/ovh

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or issues
  • I have added acceptance tests that prove my fix is effective or that my feature works
  • New and existing acceptance tests pass locally with my changes
  • I ran succesfully go mod vendor if I added or modify go.mod file

@alexGNX alexGNX requested a review from a team as a code owner August 28, 2025 15:03
@alexGNX alexGNX force-pushed the dev/agagneux/okms_secret branch 2 times, most recently from 689e9d7 to a3bec7e Compare August 28, 2025 16:16
@alexGNX alexGNX force-pushed the dev/agagneux/okms_secret branch from a3bec7e to 18ed924 Compare September 1, 2025 06:49
@alexGNX alexGNX force-pushed the dev/agagneux/okms_secret branch from 18ed924 to 13a67aa Compare September 1, 2025 16:43
@alexGNX alexGNX force-pushed the dev/agagneux/okms_secret branch from 13a67aa to 85a7605 Compare September 3, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants