feat(pci-block-storage): migrate retype page to ODS19 and drawer #19029
+188
−174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aTurmo
requested review from
manoncarbonnel,
ppprevost,
lionel95200x,
Tsiorifamonjena,
lolottetheclash and
fredericvilcot
aTurmo
force-pushed
the
feat/TAPC-4915_retyping_ods19
branch
2 times, most recently
from
0d015d3 to
49bbf1d
Compare
aTurmo
force-pushed
the
feat/TAPC-4915_retyping_ods19
branch
from
49bbf1d to
7c904e5
Compare
Tsiorifamonjena
approved these changes
Sep 10, 2025
packages/manager/apps/pci-block-storage/src/pages/retype/Retype.page.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-block-storage/src/components/VolumeModelTilesInput.component.tsx
Outdated
Show resolved
Hide resolved
ppprevost
reviewed
Sep 10, 2025
packages/manager/apps/pci-block-storage/src/components/VolumeModelTilesInput.component.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-block-storage/src/components/VolumeModelTilesInput.component.tsx
Show resolved
Hide resolved
I don't understand why it fails because the only error are from pci-instances 
|
aTurmo
force-pushed
the
feat/TAPC-4915_retyping_ods19
branch
from
7c904e5 to
6cefa96
Compare
aTurmo
force-pushed
the
epic/TAPC-4377-volume-retyping
branch
from
8588d14 to
9a7a444
Compare
ref: #TAPC-4915 Signed-off-by: Adrien Turmo <[email protected]>
aTurmo
force-pushed
the
feat/TAPC-4915_retyping_ods19
branch
from
6cefa96 to
5f3e012
Compare
I rebased branches and now it's good |
lolottetheclash
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #TAPC-4915
Result:
