[GR-65773] Integrate foreign configuration into reachability-metadata.json #11805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
graalvmbot
force-pushed
the
lottet/GR-65773-ffi-json
branch
from
ba5f685 to
31be89d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the currently standalone
foreign-config.jsonas an additional"foreign"section ofreachability-metadata.json. The internal structure of the file is preserved. The PR also modifies formatting to match what's already done inreachability-metadata.json(i.e. the unmodified use ofJsonPrettyWriter).As
foreign-config.jsonwas never part of a GraalVM release, the PR completely deletes it instead of providing legacy support like what has been done forreflect-config.jsonand others. This change will be backported to the 25.0 release as well.