[GR-65268] Support Arena.ofShared with runtime compilations. #11788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
graalvmbot
force-pushed
the
topic/GR-65268
branch
from
db5d4d2 to
1e6bcc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment,
Arena.ofShared(if enabled with-H:+SharedArenaSupport) does not work with runtime compilations. The image build already fails when attempting to instrument the@Scopedannotated methods because the expected structure is different.This PR fixes that problem and prepares
SubstrateOptimizeSharedArenaAccessPhasefor use with runtime compilations.However, we still do not instrument the deoptimization targets because for those, we cannot simply fake frame states.
So, shared sessions cannot be used safely in deoptimization targets at the moment.
This PR therefore introduces a check that does not allow shared sessions to be used in runtime compiled
@Scope-annotated methods (an exception will be thrown at run time).