[GR-65625] [GR-66764] Refine layer compatibility checking for build options. #11529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tation Use this new ability to provide a more forgiving layer option compatibility check for `-g` (only raise error if current uses `-g` but prev. does not have it (other way around is ok)). Note that is still holds up the more strict check for arbitrary -H:GenerateDebugInfo use.
A native image can anyway never make assumptions about RuntimeOptionKey option-values. Thus, there is never the need to verify if a prev layer build uses the same as the current layer. And as for the default value for a RuntimeOptionKey, the last one, wins.
Check the image name requirements early so that we cannot even build a base-layer that would be unusable due to its image name.
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.