[GR-60508] Include more information in the hash of method handle invoker substitution names #10324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeSwitchlambda forms contain a reference to aNamedFunctionwith a non nullintrinsicDatarepresenting the number of case of the switch.This needs to be included in the hash computation to avoid conflicts.
This also implies that the
resolvedHandleneeds to be included in the hash even for non null members.Additionally, since
MethodHandleInvokerRenamingSubstitutionProcessoris tied to the implementation ofMethodHandleandLambdaForm, this PR adds@BasedOnJDKClassannotations to monitor the changes in the JDK.