Skip to content

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Sep 18, 2025

This change showcases that changes in Cluster resource triggers reconiliation of Job resources.

@openshift-ci openshift-ci bot requested review from metacosm and xstefank September 18, 2025 13:14
@csviri csviri requested review from metacosm and removed request for metacosm September 18, 2025 13:15
@csviri
Copy link
Collaborator Author

csviri commented Sep 19, 2025

@metacosm @xstefank not sure how that integration test is readable for you / users, we might want to separate the IT for the two appraoch types.

@csviri
Copy link
Collaborator Author

csviri commented Sep 22, 2025

@metacosm @xstefank can I merge this?

@metacosm
Copy link
Collaborator

@metacosm @xstefank not sure how that integration test is readable for you / users, we might want to separate the IT for the two appraoch types.

I think that it'd be better indeed to split this to make things clearer.

@csviri
Copy link
Collaborator Author

csviri commented Sep 22, 2025

@metacosm @xstefank not sure how that integration test is readable for you / users, we might want to separate the IT for the two appraoch types.

I think that it'd be better indeed to split this to make things clearer.

can do it as a separate PR

@xstefank
Copy link
Collaborator

@csviri just making sure if you are going to separate it? Or should I review this PR?

@csviri
Copy link
Collaborator Author

csviri commented Sep 22, 2025

@csviri just making sure if you are going to separate it? Or should I review this PR?

Pls review, we can later separate it, but it is PR anyways already done, and show that the change on Cluster reconiliation works.

Later we can break it down to two separate tests. One that uses the PrimaryToSecondaryMapper one that does not, but both of those cases we want to have this test case

Signed-off-by: Attila Mészáros <[email protected]>
@csviri csviri force-pushed the job-reconciler-improve branch from bd0c450 to 226607f Compare September 22, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants