improve: showcase initialized spec deleted when adding finalizer with SSA with same fieldManager #2847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csviri
changed the title
csviri
changed the title
xstefank
approved these changes
Sep 22, 2025
metacosm
changed the title
metacosm
requested changes
Sep 23, 2025
|
|
||
| // List is initialized, that at the end becomes problematic when adding the finalizer | ||
| // If the list is not initialized like this (this its null) it works fine | ||
| private List<String> list = new ArrayList<>(); |
There was a problem hiding this comment.
Does the issue only happen when the list is initialized with an empty list?
There was a problem hiding this comment.
removed this comment, had to bit reformutate the PR, the message is not that surprising this way, but still will be worth to make a small blogpost and reference this and the other IT (#2848)
in it.
.../test/java/io/javaoperatorsdk/operator/baseapi/ssaissue/finalizer/SSAFinalizerIssueSpec.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
csviri
force-pushed
the
ssa-issue-showcase
branch
from
c56b698 to
db079ac
Compare
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
csviri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.