implement support for receiving multipart edge messages #624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plorenz
reviewed
Sep 13, 2024
| @@ -153,14 +153,23 @@ func (ec *MsgChannel) WriteTraced(data []byte, msgUUID []byte, hdrs map[int32][] | |||
| copyBuf := make([]byte, len(data)) | |||
| copy(copyBuf, data) | |||
|
|
|||
| msg := NewDataMsg(ec.id, ec.msgIdSeq.Next(), copyBuf) | |||
| seq := ec.msgIdSeq.Next() | |||
| msg := NewDataMsg(ec.id, seq, copyBuf) | |||
| if msgUUID != nil { | |||
| msg.Headers[UUIDHeader] = msgUUID | |||
| } | |||
|
|
|||
| for k, v := range hdrs { | |||
| msg.Headers[k] = v | |||
| } | |||
There was a problem hiding this comment.
Could we send this back on the connect reply instead?
There was a problem hiding this comment.
connect reply goes to ER/controller and not to the peer SDK
plorenz
approved these changes
Sep 16, 2024
ekoby
force-pushed
the
multipart-receive
branch
from
c6f01c3 to
8c6985b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this only implements support for receiving multipart messages
issue for sending multipart is #623