Skip to content

More silent rules; parallelise mancheck #17747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

More silent rules; parallelise mancheck #17747

wants to merge 3 commits into from
+36 −10

Conversation

robn
Copy link
Member

@robn robn commented Sep 15, 2025 •
edited
Loading

[Sponsors: Klara, Inc., Wasabi Technology, Inc.]

Motivation and Context

The compile is all nice and quiet, and then checkstyle is a noise machine. This makes shellcheck, checkbashisms and mancheck run under automake "silent" rules (pretty output, respond to V=1, etc).

It all works better if the programs are one run per input file, so I made mancheck take a single file too. And now something like make checkstyle -j6 is extra speedy.

How Has This Been Tested?

Ran make targets checkstyle, shellcheck, checkbashisms and mancheck with V=0, V=1, -jX, and everything looks sensible.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

behlendorf
behlendorf approved these changes Sep 15, 2025
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so much nicer. Just a couple typos.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Sep 15, 2025
robn added 3 commits September 16, 2025 09:18
@robn
Shellcheck.am: add silent rules for shellcheck and checkbashisms
e78a92d 
Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.
Signed-off-by: Rob Norris <[email protected]>
@robn
mancheck: allow single files
9ef35ea 
Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.
Signed-off-by: Rob Norris <[email protected]>
@robn
man: add silent rules for mancheck
e218139 
Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.
Signed-off-by: Rob Norris <[email protected]>
@robn robn force-pushed the more-silent-rules branch from 7b4e16a to e218139 Compare September 15, 2025 23:18
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Sep 15, 2025
behlendorf pushed a commit that referenced this pull request Sep 17, 2025
@robn @behlendorf
mancheck: allow single files
45ac604 
Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.
Reviewed-by: Paul Dagnelie <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Rob Norris <[email protected]>
Closes #17747
behlendorf pushed a commit that referenced this pull request Sep 17, 2025
@robn @behlendorf
man: add silent rules for mancheck
d366842 
Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.
Reviewed-by: Paul Dagnelie <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Rob Norris <[email protected]>
Closes #17747
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Sep 17, 2025
@robn @behlendorf
Shellcheck.am: add silent rules for shellcheck and checkbashisms
4698208 
Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.
Reviewed-by: Paul Dagnelie <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Rob Norris <[email protected]>
Closes openzfs#17747
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Sep 17, 2025
@robn @behlendorf
mancheck: allow single files
d0084a4 
Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.
Reviewed-by: Paul Dagnelie <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Rob Norris <[email protected]>
Closes openzfs#17747
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Sep 17, 2025
@robn @behlendorf
man: add silent rules for mancheck
e3eb3ca 
Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.
Reviewed-by: Paul Dagnelie <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Rob Norris <[email protected]>
Closes openzfs#17747
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

+1 more reviewer

@pcd1193182 pcd1193182 pcd1193182 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robn @pcd1193182 @behlendorf