Skip to content

Fix a printf format specifier on FreeBSD/i386 #17705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2025
Merged

Fix a printf format specifier on FreeBSD/i386 #17705

merged 1 commit into from
Sep 17, 2025

Conversation

asomers
Copy link
Contributor

@asomers asomers commented Sep 8, 2025

This is breaking the build on FreeBSD/i386

Signed-off-by: Alan Somers [email protected]
Sponsored by: ConnectWise

Motivation and Context

OpenZFS does not currently build on FreeBSD i386

Description

See commit message

How Has This Been Tested?

Build tested only

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@asomers asomers mentioned this pull request Sep 8, 2025
Closed
14 tasks
amotin
amotin reviewed Sep 9, 2025
View reviewed changes
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Sep 9, 2025
@asomers asomers requested a review from amotin September 17, 2025 19:01
amotin
amotin approved these changes Sep 17, 2025
View reviewed changes
Copy link
Member

@amotin amotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but you may want to squash the commits to make checkstyle happy.

@asomers
Fix a printf format specifier on FreeBSD/i386
eece86f 
This is breaking the build on FreeBSD/i386.  Originally committed
downstream as freebsd/freebsd-src@2d76470b701

Signed-off-by:	Alan Somers <[email protected]>
Sponsored by:	ConnectWise
@asomers
Copy link
Contributor Author

asomers commented Sep 17, 2025

squashed

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Sep 17, 2025
@behlendorf behlendorf merged commit 545d662 into openzfs:master Sep 17, 2025
21 of 25 checks passed
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Sep 17, 2025
@asomers @behlendorf
Fix a printf format specifier on FreeBSD/i386
ef9b7dd 
This is breaking the build on FreeBSD/i386.  Originally committed
downstream as freebsd/freebsd-src@2d76470b701

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Signed-off-by:	Alan Somers <[email protected]>
Sponsored by:	ConnectWise
Closes openzfs#17705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@amotin amotin amotin approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asomers @behlendorf @amotin