-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Simplify fetching entire trip from an estimatedCall #6811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev-2.x
Are you sure you want to change the base?
Conversation
…imatedCalls on the same ServiceJourney, on the given date
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6811 +/- ##
==========================================
Coverage 71.96% 71.97%
- Complexity 19423 19426 +3
==========================================
Files 2099 2099
Lines 78756 78769 +13
Branches 7970 7970
==========================================
+ Hits 56680 56697 +17
- Misses 19257 19258 +1
+ Partials 2819 2814 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…imatedCalls on the same ServiceJourney, on the given date
requestStop: Boolean! | ||
serviceJourney: ServiceJourney! | ||
"All estimated calls for the ServiceJourney on this date." | ||
serviceJourneyEstimatedCalls: [EstimatedCall!]! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it not make sense to return the ServiceJourney
on a specific day? I see that you already have a field for the DatedServiceJourney
which does something similar.
(I don't know if you already have a type for this in the schema...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I chose to add this as serviceJourneyEstimatedCalls
because a field with the same name, type and functionality already exists in leg
for a similar purpose.
(https://github.com/opentripplanner/OpenTripPlanner/blob/dev-2.x/application/src/main/resources/org/opentripplanner/apis/transmodel/schema.graphql#L388)
For a ServiceJourney
on a specific day, the only part that is dependent on the operating-date will be the estimatedCalls
-part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to see something like this:
serviceJourneyEstimatedCalls : SJEstimatedCalls!
type SJEstimatedCalls {
first : EstimatedCall
last : EstimatedCall
next(antall : Int) : [EstimatedCall!]!
previous(antall : Int) : [EstimatedCall!]!
}
We are rethinking this. An issue is on its way. |
We frequently get questions on how the fetch the rest of the trip - for the correct date - on e.g. departure-board-queries.
This PR adds the possibility to fetch this more easily.